Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix a typo: occurences -> occurrences #5575

Merged
merged 1 commit into from Apr 4, 2017
Merged

Conversation

felixonmars
Copy link
Contributor

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
License MIT
Doc PR no
Dependency Changes no

@mention-bot
Copy link

@felixonmars, thanks for your PR! By analyzing the history of the files in this pull request, we identified @loganfsmyth, @hzoo and @existentialism to be potential reviewers.

@codecov
Copy link

codecov bot commented Apr 3, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@b3c7337). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master    #5575   +/-   ##
=========================================
  Coverage          ?   84.44%           
=========================================
  Files             ?      204           
  Lines             ?     9599           
  Branches          ?     2696           
=========================================
  Hits              ?     8106           
  Misses            ?     1006           
  Partials          ?      487
Impacted Files Coverage Δ
packages/babel-generator/src/index.js 88.23% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b3c7337...ae68be8. Read the comment docs.

Copy link
Member

@xtuc xtuc left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tests are green, LGTM 👍

@existentialism existentialism added the PR: Internal 🏠 A type of pull request used for our changelog categories label Apr 3, 2017
@aaronang
Copy link
Member

aaronang commented Apr 4, 2017

@felixonmars Thanks a lot 🎉

@aaronang aaronang merged commit 9b4c33d into babel:master Apr 4, 2017
@felixonmars felixonmars deleted the patch-1 branch April 4, 2017 15:16
pwmckenna pushed a commit to pwmckenna/babel that referenced this pull request Apr 26, 2017
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
* 'master' of github.com:hulkish/babel: (37 commits)
  Increase the code coverage for traverse evaluation (babel#5363)
  Improve options documentation for `babel-plugin-transform-runtime` babel#5401
  [doc] Fix: comments in usage w/ options babel#5400
  document cache option for babel-register babel#5440
  Update coffescript/register reference link address babel#5475
  Update babel-generator's README babel#5517
  Improve example of babel-plugin-transform-es2015-arrow-functions babel#5573
  Remove incorrect docs. babel#5580
  Update transform-es2015-modules-commonjs doc babel#5588
  Fix replacing function declaration in export default (fixes babel#4468) (babel#5456)
  Fix a typo: occurences -> occurrences (babel#5575)
  Fix changelog [skip ci]
  Treat "await" as an invalid identifier (babel#4954)
  Removes unused lodash dependency from babel-helper-builder-react-jsx (babel#5486)
  docs: [skip ci] update documentation
  v6.24.0
  changelog for 6.24.0 [skip ci] (babel#5452)
  Keep parentheses for logical expression when in await expression (fix babel#5428) (babel#5433) (babel#5453)
  Use absolute paths in Babel's CONTRIBUTING.md (babel#5431)
  Fixed broken links in README.md [skip ci] (babel#5449)
  ...
hulkish pushed a commit to hulkish/babel that referenced this pull request May 3, 2017
jridgewell pushed a commit to jridgewell/babel that referenced this pull request May 3, 2017
jridgewell pushed a commit to jridgewell/babel that referenced this pull request May 6, 2017
fforres pushed a commit to fforres/babel that referenced this pull request May 15, 2018
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants