New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update regenerator-transform to new version #5567
Conversation
@existentialism Sorry, I made a mistake, I was trying to PR into 6.x, and I didn't see that the default branch was 7.0. My mistake. I'll close this one and try to re-open a new one I guess? |
@existentialism Huh, didn't know you could do that in the github UI. Thanks! I ran tests locally on top of 7.0, but if CI finds a problem, I'll fix it. ETA: looks like tests passed both locally and in CI. Yay! |
Codecov Report
@@ Coverage Diff @@
## 6.x #5567 +/- ##
==========================================
- Coverage 85.47% 84.48% -0.99%
==========================================
Files 200 204 +4
Lines 9506 9599 +93
Branches 2702 2696 -6
==========================================
- Hits 8125 8110 -15
- Misses 886 1002 +116
+ Partials 495 487 -8
Continue to review full report at Codecov.
|
Hey Babel folks, I'm at a loss on this code coverage report saying that this commit makes coverage go down in 100+ files. That doesn't make a lot of sense to me, given that I didn't change any Babel product code, and I added a test. Any help/guidance you could provide would be great; thanks! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
It's good also to cover this case - facebook/regenerator#277 since it includes changes provided in 0.9.9
. Or I could make a separate PR. 👌
Also maybe facebook/regenerator#283 which is for this issue: #4219 |
I added a test case to this PR for #4219. |
There was a bug with the code produced by
regenerator-transform
when it runs on an object with a shorthand property generator; the code produced by the transform created an undefined variable. In normal usage in Babel, this was usually masked by the fact that almost everyone usesbabel-plugin-transform-regenerator
afterbabel-plugin-transform-es2015-shorthand-properties
, so the regenerator transformation was never seeing untransformed shorthand properties. (Also, shorthand property generators are not super common.)I reported this problem in facebook/regenerator#267, and it was merged and released to npm in February. This PR updates
babel-plugin-transform-regenerator
to depend on that new version orregenerator-transform
, and adds a unit test that fails with the old version ofregenerator-transform
.Thanks for all the great work you do for the web and the world!