Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removes unused lodash dependency from babel-helper-builder-react-jsx #5486

Merged
merged 1 commit into from Mar 16, 2017
Merged

Removes unused lodash dependency from babel-helper-builder-react-jsx #5486

merged 1 commit into from Mar 16, 2017

Conversation

segphault
Copy link
Contributor

Q A
Patch: Bug Fix? no
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy? no
Tests Added/Pass? no
Fixed Tickets Fixes #5482
License MIT
Doc PR no
Dependency Changes Removes unused lodash dependency

Removes an unused lodash dependency from babel-helper-builder-react-jsx

@mention-bot
Copy link

@segphault, thanks for your PR! By analyzing the history of the files in this pull request, we identified @forivall, @loganfsmyth and @kutyel to be potential reviewers.

@codecov
Copy link

codecov bot commented Mar 16, 2017

Codecov Report

Merging #5486 into master will decrease coverage by 0.05%.
The diff coverage is n/a.

@@            Coverage Diff             @@
##           master    #5486      +/-   ##
==========================================
- Coverage   84.47%   84.42%   -0.06%     
==========================================
  Files         204      204              
  Lines        9597     9597              
  Branches     2695     2695              
==========================================
- Hits         8107     8102       -5     
- Misses       1003     1008       +5     
  Partials      487      487
Impacted Files Coverage Δ
packages/babel-helper-call-delegate/src/index.js 64% <0%> (-4%)
packages/babel-traverse/src/path/context.js 84.48% <0%> (-1.73%)
packages/babel-traverse/src/path/modification.js 73.78% <0%> (-0.98%)
...bel-plugin-transform-es2015-classes/src/vanilla.js 89.74% <0%> (-0.43%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update ad1edc6...f5a4875. Read the comment docs.

@hzoo hzoo merged commit 8859715 into babel:master Mar 16, 2017
@hzoo hzoo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Apr 7, 2017
hulkish added a commit to hulkish/babel that referenced this pull request May 2, 2017
* 'master' of github.com:hulkish/babel: (37 commits)
  Increase the code coverage for traverse evaluation (babel#5363)
  Improve options documentation for `babel-plugin-transform-runtime` babel#5401
  [doc] Fix: comments in usage w/ options babel#5400
  document cache option for babel-register babel#5440
  Update coffescript/register reference link address babel#5475
  Update babel-generator's README babel#5517
  Improve example of babel-plugin-transform-es2015-arrow-functions babel#5573
  Remove incorrect docs. babel#5580
  Update transform-es2015-modules-commonjs doc babel#5588
  Fix replacing function declaration in export default (fixes babel#4468) (babel#5456)
  Fix a typo: occurences -> occurrences (babel#5575)
  Fix changelog [skip ci]
  Treat "await" as an invalid identifier (babel#4954)
  Removes unused lodash dependency from babel-helper-builder-react-jsx (babel#5486)
  docs: [skip ci] update documentation
  v6.24.0
  changelog for 6.24.0 [skip ci] (babel#5452)
  Keep parentheses for logical expression when in await expression (fix babel#5428) (babel#5433) (babel#5453)
  Use absolute paths in Babel's CONTRIBUTING.md (babel#5431)
  Fixed broken links in README.md [skip ci] (babel#5449)
  ...
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
6.x: backport outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Remove lodash dep from babel-helper-builder-react-jsx
3 participants