Add new flow preset #5288
Add new flow preset #5288
Conversation
|
@thejameskyle, thanks for your PR! By analyzing the history of the files in this pull request, we identified @xtuc, @hzoo and @gitanupam to be potential reviewers. |
|
Oh hi @mention-bot, you're interesting |
|
|
||
| export default { | ||
| plugins: [ | ||
| transformSyntaxFlow, |
There was a problem hiding this comment.
I see this was in there, weird. This isn't needed, the transform already loads this: https://github.com/babel/babel/blob/master/packages/babel-plugin-transform-flow-strip-types/src/index.js#L5
There was a problem hiding this comment.
Yeah I believe I asked about this earlier and sebastian or someone said it was just for clarity if someone read the file
There was a problem hiding this comment.
Hmm, I mean it's pretty much a no-op, but I feel like we should remove them, otherwise people reading the presets would think this is necessary.
jamiebuilds
force-pushed
the
preset-flow
branch
from
01f76e3
to
6cbaa36
Compare
|
Hey @thejameskyle! It looks like one or more of your builds have failed. I've copied the relevant info below to save you some time. |
jamiebuilds
force-pushed
the
preset-flow
branch
from
6cbaa36
to
b43e09c
Compare
|
|
||
| **In** | ||
|
|
||
| ```javascript |
There was a problem hiding this comment.
Not a huge deal, but probably don't need an example at the preset level (we don't have them for any of the others)?
There was a problem hiding this comment.
I still like having it, it doesn't do any harm
hzoo
added
the
PR: New Feature 🚀
* Add new flow preset (#5288) * Fix PathHoister hoisting JSX member expressions on "this". (#5143) The PathHoister ignored member references on "this", causing it to potentially hoist an expression above its function scope. This patch tells the hoister to watch for "this", and if seen, mark the nearest non-arrow function scope as the upper limit for hoistng. This fixes #4397 and is an alternative to #4787. * Fix PathHoister hoisting before bindings. (#5153) Fixes #5149 and enables a few additional safe hoists. * Fix linting error * feature: Support pure expressions in transform-react-constant-elements (#4812) * Fix loose for-of with label (#5298) * Rewrite Hub as interface #5047 (#5050) * Rewrite Hub as interface #5047 * Update index.js * Avoid adding unnecessary closure for block scoping (#5246) When you write ``` for (const x of l) { setTimeout(() => x); } ``` we need to add a closure because the variable is meant to be block-scoped and recreated each time the block runs. We do this. However, we also add the closure when no loop is present. This isn't necessary, because if no loop is present then each piece of code runs at most once. I changed the transform to only add a closure if a variable is referenced from within a loop. * Add greenkeeperio-bot to mention-bot blacklist (#5301) [skip ci] * Upgrade lerna to current beta. (#5300) * Revert "Upgrade lerna to current beta." (#5303) * Add charset so tests work with convert-source-map@>1.4 (#5302) * Add CHANGELOG for 6.23.0 [skip ci] (#5304) * Update babel-types README from script. * v6.23.0 * Revert change that lerna force-committed. * Revert "Rewrite Hub as interface #5047" (#5306) * v6.23.1 * Revert lerna again
lock
bot
added
the
outdated
preset-flowplugin-syntax-flowandplugin-transform-flow-strip-typeswithpreset-flow