Navigation Menu

Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deopt evaluation of undefined with a local binding. Fix #5204 #5206

Merged
merged 1 commit into from Feb 8, 2017

Conversation

boopathi
Copy link
Member

Q A
Patch: Bug Fix? yes
Major: Breaking Change? no
Minor: New Feature? no
Deprecations? no
Spec Compliancy?
Tests Added/Pass? yes
Fixed Tickets Fixes #5204
License MIT
Doc PR
Dependency Changes

undefined, NaN, Infinity with local bindings - deopt during path.evaluate.

@mention-bot
Copy link

@boopathi, thanks for your PR! By analyzing the history of the files in this pull request, we identified @hzoo, @DrewML and @erikdesjardins to be potential reviewers.

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol

@codecov-io
Copy link

codecov-io commented Jan 24, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@aa7817b). Click here to learn what that means.

@@            Coverage Diff            @@
##             master    #5206   +/-   ##
=========================================
  Coverage          ?   89.25%           
=========================================
  Files             ?      203           
  Lines             ?     9838           
  Branches          ?     2627           
=========================================
  Hits              ?     8781           
  Misses            ?     1057           
  Partials          ?        0
Impacted Files Coverage Δ
packages/babel-traverse/src/path/evaluation.js 78.68% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update aa7817b...a8a3af6. Read the comment docs.

@hzoo hzoo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Feb 8, 2017
@hzoo hzoo merged commit f8ffe03 into master Feb 8, 2017
@boopathi boopathi deleted the eval-undef-binding-0 branch February 8, 2017 15:43
@lock lock bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 6, 2019
@lock lock bot locked as resolved and limited conversation to collaborators Oct 6, 2019
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

path.evalute() should not be confident for local undefined variable
5 participants