Prevent multiple return statements in a loop when replacing expressions #5030
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
existentialism
added
the
PR: Bug Fix 🐛
Codecov Report@@ Coverage Diff @@
## master #5030 +/- ##
==========================================
+ Coverage 89.15% 89.17% +0.02%
==========================================
Files 203 203
Lines 9823 9824 +1
Branches 2616 2615 -1
==========================================
+ Hits 8758 8761 +3
+ Misses 1065 1063 -2
Continue to review full report at Codecov.
|
|
Nice job! 👍 |
Jessidhia
reviewed
Dec 22, 2016
| let uid = loop.getData("expressionReplacementReturnUid"); | ||
|
|
||
| if (!uid) { | ||
| let callee = this.get("callee"); |
| @@ -0,0 +1,9 @@ | |||
| let a = do { | |||
| while (p = p.parentPath) { | |||
There was a problem hiding this comment.
I'd feel better if there was a let p before the let a 😃
loganfsmyth
reviewed
Feb 4, 2017
| uid = callee.scope.generateDeclaredUidIdentifier("ret"); | ||
| callee.get("body").pushContainer("body", t.returnStatement(uid)); | ||
| loop.setData("expressionReplacementReturnUid", uid); | ||
| } |
There was a problem hiding this comment.
We should probably do
} else {
uid = t.identifier(uid.name);
}
or else we'll be inserting the same identifier node in multiple places in the AST.
|
One small comment, and this has a conflict, but otherwise looks good. |
existentialism
force-pushed
the
issue5022
branch
from
edf5bdb
to
9c46fd6
Compare
loganfsmyth
approved these changes
Feb 9, 2017
existentialism
added a commit
that referenced
this pull request
May 19, 2017
lock
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Could definitely use some guidance on this, as I'm still digging through a lot of this :P