Treat "await" as an invalid identifier #4954
Conversation
It is valid (outside `async` functions) in the "script" parse goal, but always invalid in the "module" parse goal. Fixes babel#4952.
Current coverage is 89.22% (diff: 100%)
|
| @@ -0,0 +1,3 @@ | |||
| export {}; | |||
|
|
|||
| var obj = { await: function _await() {} }; | |||
There was a problem hiding this comment.
In chrome this happens - so defining await inside async function is syntax error. Not sure if it's a chrome bug that defining it outside is not a syntax error...
There was a problem hiding this comment.
The fn.name also changes when it's derived to be arguments or another keyword; not much can be done about it other than omitting the name entirely and leaving it to ES6 engines to correctly derive the name...
And yes, Chrome's error is correct. You cannot use a keyword in a var/let/const binding, and explicitly named functions create a var binding with their name.
There was a problem hiding this comment.
Oh, defining it outside is not a syntax error in strict mode -- it is a syntax error with the module parse goal, which only exists in Chakra(?) and parsers for now.
hzoo
added
the
PR: Bug Fix 🐛
|
This is kindof a duplicate/workaround of #4198 |
|
ping! This is breaking our app in Edge. Would love to see it resolved quickly please let me know if there is anything I can contribute to help make that possible. It seems like @danez s the best solution but seems blocked upstream. Perhaps we could go with a local fix until folks upstream have the time to address it more thoroughly? |
* 'master' of github.com:hulkish/babel: (37 commits) Increase the code coverage for traverse evaluation (babel#5363) Improve options documentation for `babel-plugin-transform-runtime` babel#5401 [doc] Fix: comments in usage w/ options babel#5400 document cache option for babel-register babel#5440 Update coffescript/register reference link address babel#5475 Update babel-generator's README babel#5517 Improve example of babel-plugin-transform-es2015-arrow-functions babel#5573 Remove incorrect docs. babel#5580 Update transform-es2015-modules-commonjs doc babel#5588 Fix replacing function declaration in export default (fixes babel#4468) (babel#5456) Fix a typo: occurences -> occurrences (babel#5575) Fix changelog [skip ci] Treat "await" as an invalid identifier (babel#4954) Removes unused lodash dependency from babel-helper-builder-react-jsx (babel#5486) docs: [skip ci] update documentation v6.24.0 changelog for 6.24.0 [skip ci] (babel#5452) Keep parentheses for logical expression when in await expression (fix babel#5428) (babel#5433) (babel#5453) Use absolute paths in Babel's CONTRIBUTING.md (babel#5431) Fixed broken links in README.md [skip ci] (babel#5449) ...
It is valid (outside `async` functions) in the "script" parse goal, but always invalid in the "module" parse goal. Fixes #4952.
lock
bot
added
the
outdated
"await" is valid (outside
asyncfunctions) as an identifier in the "script" parse goal, but always invalid in the "module" parse goal. Prevents the transform from generating invalid code when used without a modules-to-script transform.This does make the function name generated for
transform-es2015-function-namenot ES2015-compliant, however, but it is probably better than breaking ES2017. An alternative is to maketransform-es2015-function-namenot give the function a name if it would have beenawait; that way ES2015 engines could still infer the correct name.