Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: guessExecutionStatusRelativeTo exception #15305

Merged
merged 3 commits into from Dec 23, 2022

Conversation

liuxingbaoyu
Copy link
Member

@liuxingbaoyu liuxingbaoyu commented Dec 23, 2022

Q                       A
Fixed Issues? Fixes #15299
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? ×
Documentation PR Link
Any Dependency Changes?
License MIT

This PR fixes two issues.

  1. path may be program, it has no parentPath.
  2. The newly added _guessExecutionStatusRelativeTo may cause an infinite loop.
    image

Changes tested locally to work at #15299 (comment), I tried to extract the minimal failure code but failed.
For reviewers,
node_modules\.bin\babel.cmd node_modules\react-hook-form\dist\index.cjs.js
You can quickly reproduce the error this way. (yarn add @babel/cli)

@liuxingbaoyu liuxingbaoyu added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: traverse i: regression labels Dec 23, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Dec 23, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53712/

@nicolo-ribaudo nicolo-ribaudo merged commit aaf76fa into babel:main Dec 23, 2022
@nicolo-ribaudo
Copy link
Member

I can work on adding tests today.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 25, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 25, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
3 participants