Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Falback to printing inner comments as trailing #15144

Merged
merged 2 commits into from Nov 7, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Nov 5, 2022

Q                       A
Fixed Issues? Fixes #15138 (comment)
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Nov 5, 2022
Comment on lines +9 to +10
C /* 2 */[]
/* 3 */;
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

/* 3 */ was not printed, this output was wrong!

It should be printed inside [], but we print [] as a single token. I'll open another PR for that.

@babel-bot
Copy link
Collaborator

babel-bot commented Nov 5, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/53369/

@nicolo-ribaudo nicolo-ribaudo merged commit 156b608 into babel:main Nov 7, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the inner-as-trailing branch November 7, 2022 16:51
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 7, 2023
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 7, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: comments outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: generator PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Inner comments for anonymous functions/classes printed in leading position
4 participants