fix: runtime-corejs 2 should depend on core-js@2 #14937
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52950/ |
JLHwung
commented
Sep 14, 2022
| (DependencyType = 'dependencies'), | ||
| % The rule works for @babel/runtime-corejs2 only | ||
| (WorkspaceIdent = '@babel/runtime-corejs2'). |
There was a problem hiding this comment.
Now yarn constraints will throw
YN0024: @babel/runtime-corejs2 must depend on core-js via ^2.6.12, but uses ^3.25.1 instead (in dependencies)
if we run yarn up core-js without yarn constraints --fix, the constraint check is in CI so we should be all good.
|
I'll release as soon as ci is green on main. |
|
Amazing, thanks! |
|
This fix does not yet appear to be pushed to NPM - is this a caching issue or did we fail to push the release? |
|
@mynnx https://www.npmjs.com/package/@babel/runtime-corejs2/v/7.19.2 This is a caching issue. |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR fixes a regression introduced in #14924: We run
yarn up core-jswithout checking that@babel/runtime-corejs2must depend oncore-js@2. This issue had happened once before but then we fixed it before we published. Anyway I draft a new yarn constraint and hopefully it won't bother us any more.