Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not remove type import used in TS import= #14913

Merged
merged 2 commits into from Sep 6, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 6, 2022

Q                       A
Fixed Issues? Fixes #14912
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The import foo = ns.bar is specially handled in the isInType check so that if ns here is an import binding, ns will not be removed by the TypeScript transform.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Sep 6, 2022
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52883/

@JLHwung JLHwung merged commit 4b3f619 into babel:main Sep 6, 2022
@JLHwung JLHwung deleted the fix-14912 branch September 6, 2022 21:12
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 7, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 7, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: TypeScript import alias can cause import to be incorrectly removed
4 participants