New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix helper-builder-react-jsx compat with Babel 7.9 #14886
Conversation
@@ -79,7 +79,7 @@ You can set \`throwIfNamespace: false\` to bypass this warning.`, | |||
"Fragment tags are only supported in React 16 and up.", | |||
); | |||
} | |||
const callExpr = buildFragmentCall(path, state.file); | |||
const callExpr = buildFragmentCall(path, state); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the key fix suggested in #14884 (comment), other source changes are refactors so that the variable names are consistent with the typings.
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52804/ |
babel/helper-builder-react-jsx held back because of babel/babel#14886, can be upgraded once the fix is released svgr needs to stay @v5: gregberge/svgr#665 (comment) "We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5." eslint-loader -> eslint-webpack-plugin @ v2 from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin" from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch." TODO: still need to do "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0", eslint 7 -> 8 didn't work easily for me..
babel/helper-builder-react-jsx held back because of babel/babel#14886, can be upgraded once the fix is released svgr needs to stay @v5: gregberge/svgr#665 (comment) "We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5." eslint-loader -> eslint-webpack-plugin @ v2 from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin" from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch." TODO: still need to do "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0", eslint 7 -> 8 didn't work easily for me..
babel/helper-builder-react-jsx held back because of babel/babel#14886, can be upgraded once the fix is released svgr needs to stay @v5: gregberge/svgr#665 (comment) "We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5." eslint-loader -> eslint-webpack-plugin @ v2 from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin" from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch." TODO: still need to do "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0", eslint 7 -> 8 didn't work easily for me..
babel/helper-builder-react-jsx held back because of babel/babel#14886, can be upgraded once the fix is released svgr needs to stay @v5: gregberge/svgr#665 (comment) "We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5." eslint-loader -> eslint-webpack-plugin @ v2 from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin" from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch." TODO: still need to do "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0", eslint 7 -> 8 didn't work easily for me..
babel/helper-builder-react-jsx held back because of babel/babel#14886, can be upgraded once the fix is released svgr needs to stay @v5: gregberge/svgr#665 (comment) "We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5." eslint-loader -> eslint-webpack-plugin @ v2 from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin" from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch." TODO: still need to do "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0", eslint 7 -> 8 didn't work easily for me..
Fix a compatibility issue between
helper-builder-react-jsx
7.18 andtransform-react-jsx
7.9, introduced in #14601. Added behaviour tests to ensure the options interfaces are correct.