Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix helper-builder-react-jsx compat with Babel 7.9 #14886

Merged
merged 2 commits into from Aug 27, 2022

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 26, 2022

Q                       A
Fixed Issues? Fixes #14884
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Fix a compatibility issue between helper-builder-react-jsx 7.18 and transform-react-jsx 7.9, introduced in #14601. Added behaviour tests to ensure the options interfaces are correct.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories i: regression labels Aug 26, 2022
@@ -79,7 +79,7 @@ You can set \`throwIfNamespace: false\` to bypass this warning.`,
"Fragment tags are only supported in React 16 and up.",
);
}
const callExpr = buildFragmentCall(path, state.file);
const callExpr = buildFragmentCall(path, state);
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is the key fix suggested in #14884 (comment), other source changes are refactors so that the variable names are consistent with the typings.

This comment was marked as resolved.

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52804/

@nicolo-ribaudo nicolo-ribaudo merged commit cad4ea7 into babel:main Aug 27, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the fix-14884 branch August 27, 2022 14:15
jonenst added a commit to gridsuite/commons-ui that referenced this pull request Aug 29, 2022
babel/helper-builder-react-jsx held back because of babel/babel#14886,
can be upgraded once the fix is released

svgr needs to stay @v5: gregberge/svgr#665 (comment)
"We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5."

eslint-loader -> eslint-webpack-plugin @ v2
from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin"
from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch."

TODO: still need to do
  "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0",
  eslint 7 -> 8
didn't work easily for me..
jonenst added a commit to gridsuite/commons-ui that referenced this pull request Aug 29, 2022
babel/helper-builder-react-jsx held back because of babel/babel#14886,
can be upgraded once the fix is released

svgr needs to stay @v5: gregberge/svgr#665 (comment)
"We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5."

eslint-loader -> eslint-webpack-plugin @ v2
from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin"
from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch."

TODO: still need to do
  "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0",
  eslint 7 -> 8
didn't work easily for me..
jonenst added a commit to gridsuite/commons-ui that referenced this pull request Aug 29, 2022
babel/helper-builder-react-jsx held back because of babel/babel#14886,
can be upgraded once the fix is released

svgr needs to stay @v5: gregberge/svgr#665 (comment)
"We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5."

eslint-loader -> eslint-webpack-plugin @ v2
from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin"
from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch."

TODO: still need to do
  "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0",
  eslint 7 -> 8
didn't work easily for me..
jonenst added a commit to gridsuite/commons-ui that referenced this pull request Aug 29, 2022
babel/helper-builder-react-jsx held back because of babel/babel#14886,
can be upgraded once the fix is released

svgr needs to stay @v5: gregberge/svgr#665 (comment)
"We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5."

eslint-loader -> eslint-webpack-plugin @ v2
from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin"
from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch."

TODO: still need to do
  "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0",
  eslint 7 -> 8
didn't work easily for me..
sBouzols pushed a commit to gridsuite/commons-ui that referenced this pull request Aug 30, 2022
babel/helper-builder-react-jsx held back because of babel/babel#14886,
can be upgraded once the fix is released

svgr needs to stay @v5: gregberge/svgr#665 (comment)
"We are moving forward, not backward. If you use webpack 4, then you should stick to SVGR v5."

eslint-loader -> eslint-webpack-plugin @ v2
from https://www.npmjs.com/package/eslint-loader "This loader has been deprecated. Please use eslint-webpack-plugin"
from https://webpack.js.org/plugins/eslint-webpack-plugin/ "This is eslint-webpack-plugin 3.0 which works only with webpack 5. For the webpack 4, see the 2.x branch."

TODO: still need to do
  "babel-eslint": "^10.1.0", -> "@babel/eslint-parser": "^7.0.0" + "@babel/eslint-plugin": "^7.0.0",
  eslint 7 -> 8
didn't work easily for me..
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 27, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 27, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
4 participants