Remove one promise tick in yield* (tc39/ecma262#2819) #14877
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52792/ |
nicolo-ribaudo
force-pushed
the
ecma262-pr-2819
branch
2 times, most recently
from
daeaad0
to
6978c93
Compare
nicolo-ribaudo
added
PR: Spec Compliance 👓
nicolo-ribaudo
force-pushed
the
ecma262-pr-2819
branch
from
6978c93
to
5a5fd7f
Compare
JLHwung
approved these changes
Aug 30, 2022
liuxingbaoyu
approved these changes
Sep 1, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1, Fixes #2This PR implements tc39/ecma262#2819, that reached consensus in the July TC39 meeting. The first commit moves the helpers to their own files without modifying them, so it's easier to only review the other commits (so that you clearly see what changes I made).
I chose to not bump the helpers min versions because this change is fully self-contained in the helpers, and because I didn't add any new parameter to their public API. Users can get this change by just updating their helpers (
@babel/runtime).