Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add proposal-record-and-tuple to standalone #14867

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Aug 21, 2022

Q                       A
Fixed Issues? Fixes #14866
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Added the transform plugin to babel-standalone.

When developing this PR, I spot that .matchInlineSnapshot does not generate snapshot automatically on the jest-light-runner. I managed to output snapshot from jest-runner.

@JLHwung JLHwung added PR: New Feature 🚀 A type of pull request used for our changelog categories pkg: standalone labels Aug 21, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented Aug 21, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52747/

@JLHwung JLHwung force-pushed the add-proposal-record-tuple-to-standalone branch from b6595f9 to 495e31a Compare August 21, 2022 13:52
@JLHwung JLHwung changed the title feat: add proposal/record-and-tuple to standalone feat: add proposal-record-and-tuple to standalone Aug 21, 2022
@nicolo-ribaudo
Copy link
Member

When developing this PR, I spot that .matchInlineSnapshot does not generate snapshot automatically on the jest-light-runner. I managed to output snapshot from jest-runner.

I have a fix for this locally, it's probably time I upload it 😛

@liuxingbaoyu
Copy link
Member

liuxingbaoyu commented Aug 27, 2022

😂
First time I know that linking to a comment can also close the whole PR haha.

@liuxingbaoyu liuxingbaoyu reopened this Aug 27, 2022
@liuxingbaoyu liuxingbaoyu added this to the 7.19.0 milestone Aug 31, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit 74853c7 into babel:main Sep 2, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the add-proposal-record-tuple-to-standalone branch September 2, 2022 16:06
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 3, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 3, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone PR: New Feature 🚀 A type of pull request used for our changelog categories PR: Ready to be Merged A pull request with already two approvals, but waiting for the next minor release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants