Add 2022-03 decorators version (stage 3) #14836

nicolo-ribaudo · 2022-08-08T14:43:32Z

Q	A
Fixed Issues?	`Fixes #1, Fixes #2`
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass?	Yes
Documentation PR Link
Any Dependency Changes?
License	MIT

This PR adds a new version of the decorators plugin, representing the stage 3 proposal that reached consensus in the March 2022 TC39 meeting: #14836 (comment)

Also, the decoratorsBeforeExport option is disallowed with the new version and decorators are always after export (this aligns with the Babel 8 behavior).

ℹ️ The first two commits only copy the 2021-12 files to 2022-03. I suggest hiding it when reviewing (https://github.com/babel/babel/pull/14836/files/915df0ba082dd55dfe5ddc0abf0967ac2ecb571c..8dd440618dbd1fd75fe467b272ccb1859f8c7865), to see the diff between the 2022-03 code/tests and the 2021-12 code/tests.

cc @pzuraq @jkrems

packages/babel-core/src/tools/build-external-helpers.ts

packages/babel-helpers/src/helpers/applyDecs2203.js

babel-bot · 2022-08-08T14:46:14Z

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52770/

jkrems

Only skimmed and left a quick question - thanks for working on this!

jkrems · 2022-08-08T14:52:58Z

.../babel-plugin-proposal-decorators/test/fixtures/2022-03-accessors--to-es2015/private/exec.js

+expect(bContext.static).toBe(false);
+expect(bContext.private).toBe(true);
+expect(typeof bContext.addInitializer).toBe('function');
+expect(typeof bContext.setMetadata).toBe('function');


I'm not sure what the expected scope for the babel implementation are but setMetadata/getMetadata have been removed in the March update: tc39/proposal-decorators@5c1cc15

Oh yes thanks I should remove them! Are there any other runtime changes?

I'll let @pzuraq take that. I've been only following the proposal progress on the sidelines. AFAIK the is* renaming and metadata split were the two notable changes. But it looks like there also might have been a unification of access..? tc39/proposal-decorators@13e07b3

Yes, unification of access was one other change we made. I'll comment with a list of all changes

pzuraq · 2022-08-08T15:21:59Z

Thanks for pushing this forward @nicolo-ribaudo! I've been meaning to and just haven't had time.

Here are all the major changes we should make sure to get in this round:

initialize on the return value for accessors has been renamed to init (this may have already been addressed)
isPrivate and isStatic renamed to private and static
Metadata has been removed
access is available for all public and private class elements
@(expr)() is no longer allowed, must wrap the whole expression in parens

I believe that's everything, reviewing the repo issues and PRs. I haven't had a chance to dig back into the actual spec changes, I'll try to find some time this week to review those and make sure nothing slipped between the cracks.

nicolo-ribaudo · 2022-08-08T17:38:33Z

Thanks @pzuraq! I updated the PR.

JLHwung · 2022-08-08T17:38:54Z

It seems to me #14666 should be part of this PR, but that one is pending tc39/ecma262#2417 (comment). I think we intend to allow @foo.#bar as decorator but not @#bar. @pzuraq Can you confirm?

JLHwung · 2022-08-08T17:40:26Z

packages/babel-helpers/src/helpers/applyDecs2203.js

@@ -0,0 +1,619 @@
+/* @minVersion 7.17.8 */


Should it be 7.19.xx?

It needs to be updated when publishing, some tests fail when helpers specify a future version.

nicolo-ribaudo · 2022-08-16T13:26:50Z

I don't know why the e2e test is failing 😕

nicolo-ribaudo · 2022-08-17T14:00:35Z

I can reproduce the failure locally downloading the CI artifact

nicolo-ribaudo · 2022-08-17T14:52:53Z

CI is green; please review again! (https://github.com/babel/babel/pull/14836/files/915df0ba082dd55dfe5ddc0abf0967ac2ecb571c..8dd440618dbd1fd75fe467b272ccb1859f8c7865)

JLHwung · 2022-08-17T15:36:39Z

Since #14353 is merged and shipped in decorator version 2021-12 and I assume that should have been a 2022-03 thing, we may want to clarify the differences between 2021-12 and 2022-03 in docs:

2021-12 <7.17.8 is indeed 2021-12
2021-12 >=7.17.8 is 2021-12 and spec updates covered in Update decorators to match latest spec #14353
2022-03 >=7.19.0 is indeed 2022-03

nicolo-ribaudo · 2022-08-17T15:53:48Z

I would word it as:

decorators valid according to the proposal as it was presented on 2021-12 can be run using version: 2021-12
decorators valid according to the proposal as it was presented on 2022-03 can be run using version: 2022-03, and it will not work with invalid decorators

because the spec updates we merged to 2021-12 are all backward compatible anyway.

nicolo-ribaudo · 2022-08-22T15:51:00Z

I prefer to always avoid it, it's simpler and generates future-proof code!

EDIT: It already works like that:

babel/packages/babel-generator/test/fixtures/decorators/decorator-parenthesized-expression/input.js

Lines 22 to 25 in 14c3f12

    
           class ShouldAddParens { 
        
             @(decs[three])() 
        
             p; 
        
           }

babel/packages/babel-generator/test/fixtures/decorators/decorator-parenthesized-expression/output.js

Lines 23 to 26 in 14c3f12

    
           class ShouldAddParens { 
        
             @(decs[three]()) 
        
             p; 
        
           }

JLHwung · 2022-08-22T16:01:00Z

Not if one enabled createParenthesizedExpressions:

babel/packages/babel-generator/test/fixtures/decorators/decorator-parenthesized-expression-createParenthesizedExpression/output.js

Line 13 in 14c3f12

@(decs[three])()

This commits add a new `allowCallParenthesized` option to the decorators parser plugin: when set to `false`, `@(...)()`-style decorators are allowed to match the stage 3 proposal presented in March 2022. It will default to `false` in Babel 8 (we might just remove the option)

This aligns with the Babel 8 behavior

* Copy `applyDecs`->`applyDecs2203` helper, and `2021-12`->`2022-03` tests * Avoid conflicting fn names in helpers * Add `2022-03` decorators version * Rename `isPrivate`/`isStatic`->`private`/`static` * Disallow `@(...)()` in 2022-03 decorators This commits add a new `allowCallParenthesized` option to the decorators parser plugin: when set to `false`, `@(...)()`-style decorators are allowed to match the stage 3 proposal presented in March 2022. It will default to `false` in Babel 8 (we might just remove the option) * Disallow `decoratorsBeforeExport` option with 2022-03 decorators This aligns with the Babel 8 behavior * Remove `.initializer` fallback for accessor properties * Remove `.initializer` fallback for accessor properties * Expose `.access` for public class elements * Remove `getMetadata`/`setMetadata` * Make the parser error recoverable * Print necessary parentheses in generator

nicolo-ribaudo added PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Decorators labels Aug 8, 2022

nicolo-ribaudo added this to the 7.19.0 milestone Aug 8, 2022

nicolo-ribaudo commented Aug 8, 2022

View reviewed changes

packages/babel-core/src/tools/build-external-helpers.ts Outdated Show resolved Hide resolved

nicolo-ribaudo commented Aug 8, 2022

View reviewed changes

packages/babel-helpers/src/helpers/applyDecs2203.js Show resolved Hide resolved

jkrems mentioned this pull request Aug 8, 2022

Implementation Status tc39/proposal-decorators#476

Open

jkrems reviewed Aug 8, 2022

View reviewed changes

pzuraq mentioned this pull request Aug 8, 2022

Static/member methods cannot access the replaced decorated class tc39/proposal-decorators#477

Closed

nicolo-ribaudo force-pushed the decorators-stage-3-updates branch from d7c3717 to cda1cec Compare August 8, 2022 17:32

nicolo-ribaudo changed the title ~~Add 2022-03 decorators version (runtime semantics)~~ Add 2022-03 decorators version (stage 3) Aug 8, 2022

nicolo-ribaudo force-pushed the decorators-stage-3-updates branch from cda1cec to f0a850b Compare August 8, 2022 17:34

nicolo-ribaudo added the PR: Needs Docs label Aug 8, 2022

JLHwung reviewed Aug 8, 2022

View reviewed changes

nicolo-ribaudo force-pushed the decorators-stage-3-updates branch 2 times, most recently from ca5415c to 65de4e7 Compare August 13, 2022 10:15

nicolo-ribaudo mentioned this pull request Aug 16, 2022

Decorators updates for 7.19.0 #14859

Merged

3 tasks

nicolo-ribaudo force-pushed the decorators-stage-3-updates branch from 492d15b to 56100c4 Compare August 16, 2022 13:13

nicolo-ribaudo mentioned this pull request Aug 17, 2022

Update Rollup packages #14860

Merged

nicolo-ribaudo force-pushed the decorators-stage-3-updates branch from fa9b7e6 to 6032754 Compare August 17, 2022 14:29

nicolo-ribaudo changed the base branch from main to feat-7.19.0/decorators August 17, 2022 14:40

nicolo-ribaudo force-pushed the decorators-stage-3-updates branch from 6032754 to 8dd4406 Compare August 17, 2022 14:41

nicolo-ribaudo force-pushed the feat-7.19.0/decorators branch from 7006391 to 4d69407 Compare August 24, 2022 14:13

nicolo-ribaudo force-pushed the decorators-stage-3-updates branch from 2767995 to 03f49bb Compare August 24, 2022 14:13

nicolo-ribaudo force-pushed the feat-7.19.0/decorators branch from 4d69407 to 08bd28c Compare August 24, 2022 14:59

nicolo-ribaudo added 12 commits August 24, 2022 16:59

Copy applyDecs->applyDecs2203 helper, and 2021-12->2022-03 tests

bd9cdfd

Avoid conflicting fn names in helpers

82c2729

Add 2022-03 decorators version

107e774

Rename isPrivate/isStatic->private/static

60464b4

Disallow decoratorsBeforeExport option with 2022-03 decorators

c7a81be

This aligns with the Babel 8 behavior

Remove .initializer fallback for accessor properties

914cb0d

Remove .initializer fallback for accessor properties

47a5e4c

Expose .access for public class elements

2cbb9fd

Remove getMetadata/setMetadata

74c11ad

Make the parser error recoverable

dbaf378

Print necessary parentheses in generator

d0ded5b

nicolo-ribaudo force-pushed the decorators-stage-3-updates branch from 03f49bb to d0ded5b Compare August 24, 2022 15:00

liuxingbaoyu self-requested a review August 29, 2022 23:02

liuxingbaoyu approved these changes Aug 29, 2022

View reviewed changes

nicolo-ribaudo merged commit a05b13b into babel:feat-7.19.0/decorators Aug 30, 2022

nicolo-ribaudo deleted the decorators-stage-3-updates branch August 30, 2022 09:42

This was referenced Aug 30, 2022

[feat request] stage 3 decorators proposal #14889

Closed

Document decorators 2022-03 version. babel/website#2672

Merged

shaneomatz mentioned this pull request Nov 18, 2022

[Snyk] Upgrade @babel/runtime from 7.12.5 to 7.20.0 shaneomatz/video.js#1

Open

github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 30, 2022

github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2022

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add 2022-03 decorators version (stage 3) #14836

Add 2022-03 decorators version (stage 3) #14836

nicolo-ribaudo commented Aug 8, 2022 •

edited

babel-bot commented Aug 8, 2022 •

edited

jkrems left a comment

jkrems Aug 8, 2022

nicolo-ribaudo Aug 8, 2022

jkrems Aug 8, 2022

pzuraq Aug 8, 2022

pzuraq commented Aug 8, 2022 •

edited

nicolo-ribaudo commented Aug 8, 2022

JLHwung commented Aug 8, 2022

JLHwung Aug 8, 2022

nicolo-ribaudo Aug 8, 2022

nicolo-ribaudo commented Aug 16, 2022

nicolo-ribaudo commented Aug 17, 2022

nicolo-ribaudo commented Aug 17, 2022

JLHwung commented Aug 17, 2022

nicolo-ribaudo commented Aug 17, 2022 •

edited

nicolo-ribaudo commented Aug 22, 2022 •

edited

JLHwung commented Aug 22, 2022

Add 2022-03 decorators version (stage 3) #14836

Add 2022-03 decorators version (stage 3) #14836

Conversation

nicolo-ribaudo commented Aug 8, 2022 • edited

babel-bot commented Aug 8, 2022 • edited

jkrems left a comment

Choose a reason for hiding this comment

jkrems Aug 8, 2022

Choose a reason for hiding this comment

nicolo-ribaudo Aug 8, 2022

Choose a reason for hiding this comment

jkrems Aug 8, 2022

Choose a reason for hiding this comment

pzuraq Aug 8, 2022

Choose a reason for hiding this comment

pzuraq commented Aug 8, 2022 • edited

nicolo-ribaudo commented Aug 8, 2022

JLHwung commented Aug 8, 2022

JLHwung Aug 8, 2022

Choose a reason for hiding this comment

nicolo-ribaudo Aug 8, 2022

Choose a reason for hiding this comment

nicolo-ribaudo commented Aug 16, 2022

nicolo-ribaudo commented Aug 17, 2022

nicolo-ribaudo commented Aug 17, 2022

JLHwung commented Aug 17, 2022

nicolo-ribaudo commented Aug 17, 2022 • edited

nicolo-ribaudo commented Aug 22, 2022 • edited

JLHwung commented Aug 22, 2022

nicolo-ribaudo commented Aug 8, 2022 •

edited

babel-bot commented Aug 8, 2022 •

edited

pzuraq commented Aug 8, 2022 •

edited

nicolo-ribaudo commented Aug 17, 2022 •

edited

nicolo-ribaudo commented Aug 22, 2022 •

edited