Inject IIFE when variables shadow binding in rest param #14736
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
the
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/52453/ |
JLHwung
reviewed
Jul 7, 2022
Comment on lines
336
to
337
| console.log(Object.keys(t.getBindingIdentifiers(pattern))); | ||
|
|
There was a problem hiding this comment.
Suggested change
| console.log(Object.keys(t.getBindingIdentifiers(pattern))); |
JLHwung
reviewed
Jul 7, 2022
| ); | ||
| } | ||
| } | ||
|
|
||
| let rest = (node.params.pop() as t.RestElement).argument as |
There was a problem hiding this comment.
Q: does rest always equal to restPath.node?
There was a problem hiding this comment.
Yes, I simplified the code and added a comment in the last commit 👍
JLHwung
approved these changes
Jul 7, 2022
liuxingbaoyu
approved these changes
Jul 7, 2022
nicolo-ribaudo
force-pushed
the
fix-param-name-conflicts-in-rest
branch
from
7b2108c
to
df261c0
Compare
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is an alternative to #14215, which takes a completely different approach (sorry @The-x-Theorist, I was reviewing&rebasing your PR, and thanks to TS I noticed that the case of "nested bindings" had not been considered 😅)
We already had the logic to handle shadowed function parameters in destructuring/defaults, and this PR re-uses it also for rest params.