Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add import-assertions to shippedProposals #14556

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 16, 2022

Q                       A
Minor: New Feature? Yes
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

The import assertions proposal has been shipped in Chrome 91 and Node.js 17.1. Therefore we should add the syntax plugin to shippedProposals.

@JLHwung JLHwung added the PR: New Feature 🚀 A type of pull request used for our changelog categories label May 16, 2022
@babel-bot
Copy link
Collaborator

babel-bot commented May 16, 2022

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51945/

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a test? We didn't have any more "shipped proposal" plugins, so all the tests had been disabled.

@nicolo-ribaudo nicolo-ribaudo added this to the v7.18.0 milestone May 17, 2022
@nicolo-ribaudo nicolo-ribaudo merged commit e57d081 into babel:main May 19, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the add-import-assertions-to-shipped-proposals branch May 19, 2022 08:34
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 19, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 19, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: preset-env PR: New Feature 🚀 A type of pull request used for our changelog categories Spec: Import Attributes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants