New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support frozen built-ins in @babel/runtime
#14537
Conversation
Jack-Works
commented
May 7, 2022
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Fixes #14527 |
Patch: Bug Fix? | 👍 |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51994/ |
hmm 1 test failed but I don't know how to fix it, it does not have a meaningful error message |
The test is a bit erratic and can be ignored. :) |
Thanks for the PR! Didn't you mention a similar problem with also a different helper? #14527 (comment) I hope one day we'll be able to run our tests with |
@babel/runtime
Done! |
packages\babel-runtime\helpers\get These two seem to need to do the same. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!