Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Restore numeric seaprators support in @babel/standalone #14427

Merged
merged 2 commits into from Apr 6, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Apr 6, 2022

Q                       A
Fixed Issues? Fixes #14425
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

When bundling @babel/standalone, we compile @babel/parser with the iterableIsArray assumption because it shrinks the bundle quite a bit. However, we must actually respect that assumption 🙃

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: standalone i: regression labels Apr 6, 2022
@nicolo-ribaudo nicolo-ribaudo marked this pull request as ready for review April 6, 2022 14:00
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51629/

@JLHwung JLHwung merged commit 7a473ed into babel:main Apr 6, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the fix-14425 branch April 6, 2022 15:41
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jul 12, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jul 12, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Numeric separators broken
4 participants