Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[2021-12] Support class decorators in export declarations #14396

Merged
merged 1 commit into from Mar 28, 2022
Merged

[2021-12] Support class decorators in export declarations #14396

merged 1 commit into from Mar 28, 2022

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Mar 27, 2022 •
edited

Q                       A
Fixed Issues? Fixes #14395
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Decorators labels Mar 27, 2022
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51575/

@nicolo-ribaudo nicolo-ribaudo merged commit 29dff68 into babel:main Mar 28, 2022
@nicolo-ribaudo nicolo-ribaudo deleted the decorated-export branch March 28, 2022 17:47
nicolo-ribaudo
nicolo-ribaudo commented Mar 28, 2022
View reviewed changes
...babel-plugin-proposal-decorators/test/fixtures/2021-12-exported/default-anonymous/output.mjs

let _A;

_dec = dec
Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Here there is a missing ExpressionStatement, I'll open a new PR.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jun 28, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jun 28, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@pzuraq pzuraq pzuraq approved these changes

@JLHwung JLHwung JLHwung approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Decorators
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: can't using decorator before or after export
4 participants
@nicolo-ribaudo @babel-bot @pzuraq @JLHwung