Parenthesize non-simple decorator expression #14378
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Bug Fix 🐛
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/51538/ |
JLHwung
commented
Mar 21, 2022
|
|
||
| @(this.foo)(bar) method3() {} |
There was a problem hiding this comment.
Added a new parser test case here.
nicolo-ribaudo
previously approved these changes
Mar 22, 2022
| { | ||
| "plugins": [["decorators", { "decoratorsBeforeExport": false }]], | ||
| "decoratorsBeforeExport": true, | ||
| "parserOpts": { "createParenthesizedExpressions": true } |
There was a problem hiding this comment.
We should also add a parser test with "createParenthesizedExpressions": true
nicolo-ribaudo
dismissed
their stale review
Whops, I approved after reviewing only the generator changes
nicolo-ribaudo
approved these changes
Mar 22, 2022
existentialism
approved these changes
Mar 22, 2022
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
@babel/generatorgenerates incorrect code@this[bar]from@(this[bar])In this PR we ensure that
@babel/generatorgenerates correct codes for non-simple decorator expressions such as@(this.foo().bar). In the first commit we mark all these non-simple expressions as "parenthesized", so that we generate correct AST for cases like@(this).bar. The second commit fixes the generator issue.The current decorator spec ("2022-03") share the same decorator expression grammar production with "2021-12" and "2018-09".