Align named imports behavior in .mjs
and .js
files
#14366
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The new behavior of defaulting to
false
is compatible with the old one, because it's strictly additive. When importing withimport * as ns
a file that exportsmodule.exports = { foo: 1 }
from an mjs file, the previous value ofns
was{ default: { foo: 1 } }
and now it will be{ default: { foo: 1 }, foo: 1 }
.This aligns the
.mjs
behavior with what we do in.js
files, and with what Node.js does.In Babel 8 we will remove
mjsStrictNamespace
option. We should probably also removestrictNamespace
, now that Node.js doesn't have that behavior anymore.