Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix duplicate declaration error on ambient class declarations #14016

Merged
merged 3 commits into from Dec 5, 2021
Merged

Fix duplicate declaration error on ambient class declarations #14016

merged 3 commits into from Dec 5, 2021

Conversation

The-x-Theorist
Copy link
Contributor

@The-x-Theorist The-x-Theorist commented Dec 2, 2021 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #13735
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

Improve the scope handling for declare class by adding a check using path.node.declare for "declare class".

@babel-bot
Copy link
Collaborator

babel-bot commented Dec 2, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/50140/

@JLHwung JLHwung changed the title Fix duplicate declaration error Fix duplicate declaration error on ambient class declarations Dec 5, 2021
@nicolo-ribaudo nicolo-ribaudo added pkg: traverse (scope) PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Dec 5, 2021
nicolo-ribaudo
nicolo-ribaudo approved these changes Dec 5, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit a943f57 into babel:main Dec 5, 2021
@The-x-Theorist The-x-Theorist deleted the duplicate-declaration-bug branch December 6, 2021 06:41
@snyk-bot snyk-bot mentioned this pull request Feb 22, 2022
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Mar 8, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Mar 8, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse (scope) PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Error when I specify "declare class" and "function" with the same name
4 participants
@The-x-Theorist @babel-bot @JLHwung @nicolo-ribaudo