New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Always expose expressionValue
in DirectiveLiteral
nodes
#13960
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 19e2332:
|
…l to main parser so it is accessible to others. Closes babel#13953. Reviewed by @tolmasky.
715e9e9
to
ff14048
Compare
Thanks! Can you run |
Sure thing |
@@ -45,7 +45,8 @@ | |||
"start":0,"end":15,"loc":{"start":{"line":1,"column":0},"end":{"line":1,"column":15}}, | |||
"extra": { | |||
"rawValue": "use\\x20strict", | |||
"raw": "'use\\x20strict'" | |||
"raw": "'use\\x20strict'", | |||
"expressionValue": "use strict" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note for reviewers: this test shows the difference between value
and expressionValue
.
expressionValue
in DirectiveLiteral
nodes
I renamed the PR so that it fits in a commit message title. Thanks! |
Closes #13953.
Reviewed by @tolmasky.
Fixes #13953