Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Throw on duplicate __proto__ props followed by assignment #13951

Merged
merged 2 commits into from Nov 12, 2021

Conversation

The-x-Theorist
Copy link
Contributor

@The-x-Theorist The-x-Theorist commented Nov 11, 2021

Q                       A
Fixed Issues? Fixes #13930
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

doubleProto will get reset only when it's used correctly, Added a check to verify the position of doubleProto if it's verified it gets reset.

@The-x-Theorist The-x-Theorist changed the title fix: no error on doubleProto with assignment expression fix: no error on doubleProto with assignment expression (fixes: #13930) Nov 11, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Nov 11, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 0b8cd91:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Nov 11, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49760/

@JLHwung JLHwung added pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories labels Nov 11, 2021
@The-x-Theorist
Copy link
Contributor Author

@JLHwung Does this commit looks good?

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

@nicolo-ribaudo nicolo-ribaudo changed the title fix: no error on doubleProto with assignment expression (fixes: #13930) Throw on duplicate __proto__ props followed by assignment Nov 12, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 135ab83 into babel:main Nov 12, 2021
@The-x-Theorist The-x-Theorist deleted the duplicate-proto-error branch November 13, 2021 06:29
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Feb 13, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Feb 13, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
4 participants