New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Throw on duplicate __proto__
props followed by assignment
#13951
Throw on duplicate __proto__
props followed by assignment
#13951
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0b8cd91:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49760/ |
...ges/babel-parser/test/fixtures/es2015/duplicate-proto/without-assignment-expression/input.js
Show resolved
Hide resolved
@JLHwung Does this commit looks good? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!
__proto__
props followed by assignment
doubleProto will get reset only when it's used correctly, Added a check to verify the position of doubleProto if it's verified it gets reset.