Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix binding access for plugin-transform-typescript #13900

Merged
merged 1 commit into from Oct 30, 2021
Merged

Fix binding access for plugin-transform-typescript #13900

merged 1 commit into from Oct 30, 2021

Conversation

PeachScript
Copy link
Contributor

@PeachScript PeachScript commented Oct 30, 2021 •
edited by JLHwung

Q                       A
Fixed Issues? --
Patch: Bug Fix? Yes, fixes #13901
Major: Breaking Change? No
Minor: New Feature? No
Tests Added + Pass? Yes
Documentation PR Link --
Any Dependency Changes? No
License MIT

Description of changes

The binding may be undefined at the changed place, and it works well before this commit change (< v7.16.0), it will cause Cannot read property 'path' of undefined error.

refer: umijs/father#418 cnpm/bug-versions#154

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49555/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 18f7965:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@PeachScript PeachScript mentioned this pull request Oct 30, 2021
Closed
JLHwung
JLHwung approved these changes Oct 30, 2021
View reviewed changes
Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you add a regression test case?

sosukesuzuki
sosukesuzuki approved these changes Oct 30, 2021
View reviewed changes
Copy link
Member

@sosukesuzuki sosukesuzuki left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh, this bug is caused by my commit! Thank you!

@JLHwung JLHwung added i: regression PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Oct 30, 2021
@littlecold233
Copy link

When this bug fix will be published? My project is broken now and I cannot downgrade the version

@nicolo-ribaudo nicolo-ribaudo merged commit c20506e into babel:main Oct 30, 2021
@nicolo-ribaudo
Copy link
Member

We need to merge #13898 and then we can release.

@nicolo-ribaudo
Copy link
Member

Released in 7.16.1

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 30, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 30, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@sosukesuzuki sosukesuzuki sosukesuzuki approved these changes

Assignees
No one assigned
Labels
area: typescript i: regression outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

@babel/plugin-transform-typescript@7.16.0 breaks transpilation
6 participants
@PeachScript @babel-bot @littlecold233 @nicolo-ribaudo @JLHwung @sosukesuzuki