extract tt.lt and tt.gt from tt.relation #13892
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JLHwung
added
PR: Internal 🏠
JLHwung
commented
Oct 28, 2021
|
|
||
| return this.finishNode(node, "FunctionTypeAnnotation"); | ||
| } | ||
| break; |
There was a problem hiding this comment.
We don't need to break for other tt.relational tokens, they will not be handled by the big switch at all and eventually thrown as unexpected token.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49607/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6d4243f:
|
JLHwung
force-pushed
the
extract-lt-gt-from-relational
branch
from
201ee1f
to
6808729
Compare
JLHwung
force-pushed
the
extract-lt-gt-from-relational
branch
from
6808729
to
6d4243f
Compare
nicolo-ribaudo
approved these changes
Nov 1, 2021
sosukesuzuki
approved these changes
Nov 1, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this PR we extract two new token
lt(<),gt(>) fromtt.relational. The base parser does not care how they are modeled as long as thebinopis correctly configured. However these tokens are heavily used in the flow/jsx/typescript plugin. Introducing new tokens will simplify how plugins match these tokens: so we can removeisRelationalandexpectRelationalmethod.This PR also splits
readToken_lt_gtintoreadToken_ltandreadToken_gt.