New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve debug logging for IgnoreList #13814
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit f0dc8d2:
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49028/ |
value: IgnoreList | IgnoreItem, | ||
): IgnoreList | IgnoreItem | string { | ||
if (value instanceof RegExp) { | ||
return inspect(value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think we need to use util.inspect
:
return inspect(value); | |
return String(value); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
That's awesome! I'll fix it
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
This PR changes the output of the debug logs when running with
DEBUG="babel:config:config-chain"
.Example:
Note how
ignore: [{}]
becomesignore: [/some-script/i]
:becomes