Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve debug logging for IgnoreList #13814

Merged
merged 2 commits into from Oct 6, 2021
Merged

Conversation

paleite
Copy link
Contributor

@paleite paleite commented Oct 4, 2021

Q                       A
Fixed Issues?
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature? Changes debug output
Tests Added + Pass? Not sure
Documentation PR Link
Any Dependency Changes? No
License MIT

This PR changes the output of the debug logs when running with DEBUG="babel:config:config-chain".

Example:

Note how ignore: [{}] becomes ignore: [/some-script/i]:

babel:config:config-chain No config is applied to "~/dev/my-repo/node_modules/@some-lib/server/some-script.js" because it matches one of `ignore: [{}]` from "~/dev/my-repo"

becomes

babel:config:config-chain No config is applied to "~/dev/my-repo/node_modules/@some-lib/server/some-script.js" because it matches one of `ignore: [/some-script/i]` from "~/dev/my-repo"

@codesandbox-ci
Copy link

codesandbox-ci bot commented Oct 4, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit f0dc8d2:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Oct 4, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/49028/

value: IgnoreList | IgnoreItem,
): IgnoreList | IgnoreItem | string {
if (value instanceof RegExp) {
return inspect(value);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I don't think we need to use util.inspect:

Suggested change
return inspect(value);
return String(value);

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's awesome! I'll fix it

Copy link
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@fedeci fedeci added pkg: core PR: Polish 💅 A type of pull request used for our changelog categories labels Oct 6, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo merged commit 7acc68a into babel:main Oct 6, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Jan 6, 2022
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Jan 6, 2022
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: core PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants