Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove imported types from export #13800

Merged
merged 2 commits into from Sep 28, 2021
Merged

fix: remove imported types from export #13800

merged 2 commits into from Sep 28, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Sep 28, 2021

Q                       A
Fixed Issues? Fixes #12499
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we register global types for imported types, so that when they are exported as values, they will be removed from exports just like other type declarations. This aligns to current tsc behaviour.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Sep 28, 2021
@babel-bot
Copy link
Collaborator

babel-bot commented Sep 28, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48923/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 28, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 21d075c:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo
Copy link
Member

Can you check that TS's --importsNotUsedAsValues option matches Babel's onlyRemoveTypeImports: true?

@JLHwung
Copy link
Contributor Author

JLHwung commented Sep 28, 2021

It seems to me TS emits same outputs among all importsNotUsedAsValues values:

// @importsNotUsedAsValues: error

// @showEmit

// @filename: child.ts
export type Node = {};


// @filename: main.ts
import type { Node } from "./child";
export { Node }

Workbench Repro

I have added a new testcase for onlyRemoveTypeImports: true.

@JLHwung JLHwung merged commit 89cab43 into babel:main Sep 28, 2021
@JLHwung JLHwung deleted the fix-12499 branch September 28, 2021 19:13
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 29, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 29, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
6 participants