Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix Gulpfile path separator issue on Windows #13795

Merged
merged 1 commit into from Sep 26, 2021

Conversation

NotWearingPants
Copy link
Contributor

@NotWearingPants NotWearingPants commented Sep 26, 2021

Q                       A
Fixed Issues? Fixes #13794
Patch: Bug Fix? 👍
Major: Breaking Change? 👎
Minor: New Feature? 👎
Tests Added + Pass? Added: 👎, Pass: 👍
Any Dependency Changes? 👎
License MIT

As described in the linked issue, I changed mapSrcToLib in Gulpfile.mjs to always use forward slashes regardless of the platform, since the Windows build was broken.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4abf13e:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48911/

@NotWearingPants NotWearingPants changed the title Fix Gulpfile path separator issue on Windows (#13794) Fix Gulpfile path separator issue on Windows Sep 26, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uh thanks!

@fedeci fedeci added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 26, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 26d0a7e into babel:main Sep 26, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 27, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 27, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Gulp build fails immediately on Windows due to path issues
4 participants