Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[@babel/node] Forward the signal SIGTERM as well #13784

Merged
merged 1 commit into from Sep 25, 2021

Conversation

julienw
Copy link
Contributor

@julienw julienw commented Sep 23, 2021

Q                       A
Fixed Issues? I haven't found any open issue about that.
Patch: Bug Fix? This forwards the TERM signal (default for kill) in addition to the existing INT signal.
Major: Breaking Change? It could be.
Minor: New Feature?
Tests Added + Pass? I'm not sure how to add one, but happy to with some guidance.
Documentation PR Link Is it necessary to document this?
Any Dependency Changes? No
License MIT

In a script I wanted to kill a previously babel-node-spawned server, but this would never kill the server, only the babel-node process.

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit d4b59b4:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48865/

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories pkg: node labels Sep 24, 2021
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo changed the title feat: forward the signal SIGTERM as well [@babel/node] Forward the signal SIGTERM as well Sep 25, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 6818b22 into babel:main Sep 25, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: node PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants