New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix regexpu-core
bundling in @babel/standalone
#13767
Fix regexpu-core
bundling in @babel/standalone
#13767
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48734/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 794e289:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🤔 I am wondering why #13765 was not caught by
babel/packages/babel-standalone/test/babel.js
Line 254 in a27c1b8
Babel.transform("/\\p{L}/u", { |
Should we mock the require
in this test?
Ideally I would like to propose a new |
I'm not sure how it could work in the past, since Node.js loads the CJS version of the plugin and we only patched the ESM version.