Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Move pipeline operator to Stage 2 #13754

Merged
merged 1 commit into from Sep 16, 2021
Merged

Conversation

sdegutis
Copy link
Contributor

@sdegutis sdegutis commented Sep 13, 2021

Q                       A
Fixed Issues? Fixes #1, Fixes #2
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 13, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit dc318ec:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added pkg: standalone PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Pipeline Operator labels Sep 13, 2021
@@ -7,6 +7,8 @@ export default (_: any, opts: any = {}) => {
useBuiltIns = false,
decoratorsLegacy = false,
decoratorsBeforeExport,
pipelineProposal = "hack",
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unfortunately changing the default is a breaking change 😅 We cannot default to hack until Babel 8.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Isn't that going to be really soon though?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Soon as in "a few months, maybe end 2021"; this PR should be a quick merge (either next patch or next minor, I'm not sure if we should consider it as a bugfix for @babel/standalone or as a new feature for the stage 2 preset).

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok will revert it later tonight when I update PR.

@sdegutis
Copy link
Contributor Author

@nicolo-ribaudo just updated it with the changes you requested, I think it now does what you want (had to do a -f push).

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48708/

@js-choi
Copy link
Contributor

js-choi commented Sep 14, 2021

Ah, I had forgotten about the Babel presets. Thanks for doing this work.

(This might need to be rebased after #13749 lands.)

@sdegutis
Copy link
Contributor Author

@js-choi @tabatkins if you guys want any more help moving forward pipelines in practice just lmk. I also plan to do the VS Code syntax highlighter change this evening (assuming they haven't), and hoping someone will update the TypeScript type checker soon to at least enable it under a stage2 flag, so I can start using it in code this year maybe.

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo changed the title Move Pipeline to Stage 2 Move pipeline operator to Stage 2 Sep 16, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 137fecc into babel:main Sep 16, 2021
@sdegutis sdegutis deleted the patch-1 branch September 16, 2021 15:54
@sdegutis
Copy link
Contributor Author

@nicolo-ribaudo Thanks for helping me figure out how to write this PR. Let me know if I can be any more help with pipelines.

@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: standalone PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Pipeline Operator
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants