New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Move pipeline operator to Stage 2 #13754
Conversation
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit dc318ec:
|
@@ -7,6 +7,8 @@ export default (_: any, opts: any = {}) => { | |||
useBuiltIns = false, | |||
decoratorsLegacy = false, | |||
decoratorsBeforeExport, | |||
pipelineProposal = "hack", |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Unfortunately changing the default is a breaking change 😅 We cannot default to hack
until Babel 8.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Isn't that going to be really soon though?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Soon as in "a few months, maybe end 2021"; this PR should be a quick merge (either next patch or next minor, I'm not sure if we should consider it as a bugfix for @babel/standalone
or as a new feature for the stage 2 preset).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok will revert it later tonight when I update PR.
@nicolo-ribaudo just updated it with the changes you requested, I think it now does what you want (had to do a -f push). |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48708/ |
Ah, I had forgotten about the Babel presets. Thanks for doing this work. (This might need to be rebased after #13749 lands.) |
@js-choi @tabatkins if you guys want any more help moving forward pipelines in practice just lmk. I also plan to do the VS Code syntax highlighter change this evening (assuming they haven't), and hoping someone will update the TypeScript type checker soon to at least enable it under a stage2 flag, so I can start using it in code this year maybe. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@nicolo-ribaudo Thanks for helping me figure out how to write this PR. Let me know if I can be any more help with pipelines. |
Fixes #1, Fixes #2