Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[eslint-parser] Represent static using a Keyword token #13751

Merged
merged 1 commit into from Sep 13, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Sep 13, 2021

Q                       A
Fixed Issues?
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

This matches ESLint's behavior - https://astexplorer.net/#/gist/f9cf0a5789035bf20a616f3d2ef06699/latest

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: eslint labels Sep 13, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48687/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 1180b02:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Contributor

@JLHwung JLHwung left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Related: I am refactoring token storage. The goal is to use number ( const enum ) as token and then we can internally categorize other keyword-like names (await, async, type, from, get, set and static) as unique keyword token type. Of course the exposed tokens will still maintain Babel 7 compatibility but we could change the tokens layout in Babel 8, which should simplify the token conversion here.

@nicolo-ribaudo nicolo-ribaudo merged commit 8af57db into babel:main Sep 13, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the eslint-static-kw branch September 13, 2021 14:35
fisker added a commit to fisker/eslint-plugin-unicorn that referenced this pull request Oct 20, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: eslint outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants