Throw a better error when transforming imported bindings in types #13739
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Sep 7, 2021
•
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #13094 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
PR: Internal 🏠
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48770/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit d8151e3:
|
JLHwung
reviewed
Sep 7, 2021
hzoo
reviewed
Sep 16, 2021
| @@ -224,6 +243,13 @@ const rewriteReferencesVisitor: Visitor<RewriteReferencesVisitorState> = { | |||
|
|
|||
| const importData = imported.get(localName); | |||
| if (importData) { | |||
| if (isInType(path)) { | |||
| throw path.buildCodeFrameError( | |||
| `Cannot transform the imported ${localName} binding since it's used in a type annotation. ` + | |||
There was a problem hiding this comment.
maybe this?
Suggested change
| `Cannot transform the imported ${localName} binding since it's used in a type annotation. ` + | |
| `Cannot transform the imported binding ${localName} since it's also used as a type annotation. ` + |
hzoo
reviewed
Sep 16, 2021
| case "TSTypeAliasDeclaration": | ||
| case "TSTypeReference": | ||
| case "TypeAnnotation": | ||
| case "TypeAlias": |
There was a problem hiding this comment.
we don't have an alias to cover all type usage for flow/ts? (or is this it anyway)
There was a problem hiding this comment.
It's enough to cover the nodes where the AST stops being an expression and starts being a type. The problem with a TypeScript/Flow catch-all is that both TS and Flow introduce some expression nodes (for example, in enums).
hzoo
approved these changes
Sep 16, 2021
fedeci
approved these changes
Sep 16, 2021
JLHwung
approved these changes
Sep 16, 2021
nicolo-ribaudo
force-pushed
the
better-error-module-transforms-in-type-annotation
branch
from
dd82738
to
d8151e3
Compare
nicolo-ribaudo
deleted the
better-error-module-transforms-in-type-annotation
branch
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.