Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove duplicate dependency and devDependency in preset-env #13737

Merged
merged 1 commit into from Sep 7, 2021
Merged

Remove duplicate dependency and devDependency in preset-env #13737

merged 1 commit into from Sep 7, 2021

Conversation

fyzhu
Copy link
Contributor

@fyzhu fyzhu commented Sep 7, 2021 •
edited

Q                       A
Fixed Issues? Fixes #13718
Patch: Bug Fix?
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48561/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Sep 7, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit c9ce52b:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

fedeci
fedeci approved these changes Sep 7, 2021
View reviewed changes
Copy link
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, it was added to dependencies at a later time.

@nicolo-ribaudo nicolo-ribaudo added the PR: Internal 🏠 A type of pull request used for our changelog categories label Sep 7, 2021
@nicolo-ribaudo nicolo-ribaudo changed the title fix: duplicate dependency in package.json of preset-env (#13718) Remove duplicate dependency and devDependency in preset-env Sep 7, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 1ebc5b7 into babel:main Sep 7, 2021
@merceyz merceyz mentioned this pull request Sep 9, 2021
Merged
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 8, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 8, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@fedeci fedeci fedeci approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Internal 🏠 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: duplicate plugin-syntax-dynamic-import in package.json of preset-env
4 participants
@fyzhu @babel-bot @fedeci @nicolo-ribaudo