fix(babel-parser): Fix end of range of SequenceExpression
#13731
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48540/ |
sosukesuzuki
added
pkg: parser
PR: Bug Fix 🐛
fedeci
approved these changes
Sep 3, 2021
JLHwung
reviewed
Sep 3, 2021
| @@ -1708,6 +1708,7 @@ export default class ExpressionParser extends LValParser { | |||
| this.finishNode(val, "SequenceExpression"); | |||
| val.end = innerEndPos; | |||
| val.loc.end = innerEndLoc; | |||
| if (this.options.ranges) val.range[1] = innerEndPos; | |||
There was a problem hiding this comment.
We can call resetEndLocation on val.
JLHwung
approved these changes
Sep 3, 2021
jridgewell
approved these changes
Sep 3, 2021
sosukesuzuki
force-pushed
the
fix-sequence-expr-range-end
branch
from
b26abde
to
6f2ae6c
Compare
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 6f2ae6c:
|
nicolo-ribaudo
approved these changes
Sep 4, 2021
|
The CI failure is not related |
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Caused by #13521.
range[1]ofSequenceExpressionis 1 more than expected.