Disallow #a in #b in c and similar expressions
#13727
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
nicolo-ribaudo
commented
Sep 2, 2021
•
nicolo-ribaudo
commented
| Q | A |
|---|---|
| Fixed Issues? | Fixes #13726 |
| Patch: Bug Fix? | |
| Major: Breaking Change? | |
| Minor: New Feature? | |
| Tests Added + Pass? | Yes |
| Documentation PR Link | |
| Any Dependency Changes? | |
| License | MIT |
nicolo-ribaudo
added
the
PR: Spec Compliance 👓
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48524/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 7779a6c:
|
jridgewell
approved these changes
Sep 2, 2021
JLHwung
reviewed
Sep 2, 2021
JLHwung
reviewed
Sep 2, 2021
sosukesuzuki
approved these changes
Sep 3, 2021
Co-authored-by: Huáng Jùnliàng <jlhwung@gmail.com>
|
Can you add a new test case? class C {
#x;
async test() {
await #x in this
}
}It was parsed successfully but should throw, probably fixed in this PR. |
JLHwung
reviewed
Sep 3, 2021
| @@ -504,7 +531,7 @@ export default class ExpressionParser extends LValParser { | |||
| const startLoc = this.state.startLoc; | |||
|
|
|||
| return this.parseExprOp( | |||
| this.parseMaybeUnary(), | |||
| this.parseMaybeUnaryOrPrivate(), | |||
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
JLHwung
approved these changes
Sep 3, 2021
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.