Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: pass browserslistEnv to resolveTargets #13697

Merged
merged 1 commit into from Aug 30, 2021
Merged

fix: pass browserslistEnv to resolveTargets #13697

merged 1 commit into from Aug 30, 2021

Conversation

meskill
Copy link
Contributor

@meskill meskill commented Aug 20, 2021 •
edited by gitpod-io bot

Q                       A
Patch: Bug Fix? Yes
Tests Added + Pass? Yes
Any Dependency Changes? No
License MIT

In case of explicitly specifying browserslist query with extends keyword, browserslistEnv option was not passed to browserslist itself leading to wrong resolved targets

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 20, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48313/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 20, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b8b67ba:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

JLHwung
JLHwung reviewed Aug 23, 2021
View reviewed changes
jest.config.js Outdated Show resolved Hide resolved
fedeci
fedeci approved these changes Aug 23, 2021
View reviewed changes
Copy link
Member

@fedeci fedeci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks!

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Aug 30, 2021
nicolo-ribaudo
nicolo-ribaudo approved these changes Aug 30, 2021
View reviewed changes
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you!

I usually ask to not commit changes to .gitignore since you can use .git/info/exclude instead. However, since this also needs change in the Jest config and since that extension looks useful (I might use it!), it's ok this time.

@nicolo-ribaudo nicolo-ribaudo changed the title fix: pass browserslistEnv to resolveTargets fix: pass browserslistEnv to resolveTargets Aug 30, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit cb3ebde into babel:main Aug 30, 2021
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Nov 30, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Nov 30, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung left review comments

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

@fedeci fedeci fedeci approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@meskill @babel-bot @JLHwung @nicolo-ribaudo @fedeci