Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ts] Fix transform for nested namespaces shorthand syntax #13664

Merged
merged 3 commits into from Aug 29, 2021
Merged

[ts] Fix transform for nested namespaces shorthand syntax #13664

merged 3 commits into from Aug 29, 2021

Conversation

nicolo-ribaudo
Copy link
Member

@nicolo-ribaudo nicolo-ribaudo commented Aug 10, 2021 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Fixes #13663
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@nicolo-ribaudo nicolo-ribaudo added PR: Bug Fix 🐛 A type of pull request used for our changelog categories area: typescript labels Aug 10, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Aug 10, 2021 •
edited

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 14651a4:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

babel-bot commented Aug 10, 2021 •
edited

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48341/

@nicolo-ribaudo nicolo-ribaudo merged commit 1355d00 into babel:main Aug 29, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the fix-ts-nested-namespace branch August 29, 2021 16:27
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Dec 10, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Dec 10, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@JLHwung JLHwung JLHwung approved these changes

@fedeci fedeci fedeci approved these changes

Assignees
No one assigned
Labels
area: typescript outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug]: Nested workspaces can't be defined with dot notation
4 participants
@nicolo-ribaudo @babel-bot @JLHwung @fedeci