New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix parse error when using named import "as" with flow parser #13659
Fix parse error when using named import "as" with flow parser #13659
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48089/ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can you add a test for
import { type foo as as } from 'name'
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 833f8ee:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Awesome!
* Add tests for babel/babel#13659 * Add tests for babel/babel#13655 * Add tests for babel/babel#13645 * Update tests
* Build(deps): Bump @babel/parser from 7.15.2 to 7.15.3 Bumps [@babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.15.2 to 7.15.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.15.3/packages/babel-parser) --- updated-dependencies: - dependency-name: "@babel/parser" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Add tests for `@babel/parser` 7.15.3 (#11366) * Add tests for babel/babel#13659 * Add tests for babel/babel#13655 * Add tests for babel/babel#13645 * Update tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sosuke Suzuki <aosukeke@gmail.com>
Update logic of the parseImportSpecifier function in the flow parser plugin to fix the issue #13520. Add related tests.