[flow] Fix parsing of arrows in conditional expressions in parentheses #13655
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nicolo-ribaudo
added
PR: Bug Fix 🐛
nicolo-ribaudo
commented
Aug 7, 2021
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "throws": "Unexpected token (1:13)" | |||
| "throws": "Unexpected token (1:12)" | |||
There was a problem hiding this comment.
The input code is const f = (x?). The old error position was at ); now it's at ?.
nicolo-ribaudo
commented
Aug 7, 2021
| @@ -1,3 +1,3 @@ | |||
| { | |||
| "throws": "Unexpected token, expected \",\" (1:65)" | |||
| "throws": "Unexpected token (1:65)" | |||
There was a problem hiding this comment.
The input code is a ? b : c ? d : e ? f : g ? h : i ? j : k ? l : m ? n : (o ? p : =);. The old error message was wrong, since there is no way we could expect , instead of =.
|
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48015/ |
|
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 985dceb:
|
nicolo-ribaudo
force-pushed
the
flow-arrows-in-ternaries-in-parens
branch
from
836215b
to
985dceb
Compare
StorytellerCZ
approved these changes
Aug 10, 2021
fedeci
approved these changes
Aug 10, 2021
existentialism
approved these changes
Aug 10, 2021
sosukesuzuki
added a commit
to sosukesuzuki/prettier
that referenced
this pull request
Aug 18, 2021
sosukesuzuki
added a commit
to prettier/prettier
that referenced
this pull request
Aug 18, 2021
* Add tests for babel/babel#13659 * Add tests for babel/babel#13655 * Add tests for babel/babel#13645 * Update tests
fisker
pushed a commit
to prettier/prettier
that referenced
this pull request
Aug 18, 2021
* Build(deps): Bump @babel/parser from 7.15.2 to 7.15.3 Bumps [@babel/parser](https://github.com/babel/babel/tree/HEAD/packages/babel-parser) from 7.15.2 to 7.15.3. - [Release notes](https://github.com/babel/babel/releases) - [Changelog](https://github.com/babel/babel/blob/main/CHANGELOG.md) - [Commits](https://github.com/babel/babel/commits/v7.15.3/packages/babel-parser) --- updated-dependencies: - dependency-name: "@babel/parser" dependency-type: direct:production update-type: version-update:semver-patch ... Signed-off-by: dependabot[bot] <support@github.com> * Add tests for `@babel/parser` 7.15.3 (#11366) * Add tests for babel/babel#13659 * Add tests for babel/babel#13655 * Add tests for babel/babel#13645 * Update tests Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com> Co-authored-by: Sosuke Suzuki <aosukeke@gmail.com>
github-actions
bot
added
the
outdated
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This was challenging, but the fixed code has less lines than the old code 😎