New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disallow reinitializing private elements #13601
Disallow reinitializing private elements #13601
Conversation
komyg
commented
Jul 26, 2021
•
edited by nicolo-ribaudo
edited by nicolo-ribaudo
Q | A |
---|---|
Fixed Issues? | Fixes #13299 |
Patch: Bug Fix | |
Major: Breaking Change? | No |
Minor: New Feature? | No |
Tests Added + Pass? | No |
Documentation PR Link | |
Any Dependency Changes? | No |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/48244/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit ebf193c:
|
packages/babel-helper-create-class-features-plugin/src/fields.ts
Outdated
Show resolved
Hide resolved
packages/babel-helper-create-class-features-plugin/src/fields.ts
Outdated
Show resolved
Hide resolved
Since #13570 has been merged, you probably need to rebase to main and write code with typings |
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
…into fix/bug-13299-class-members
Done! Thank you for the typings by the way. They will be very hepful. |
packages/babel-helper-create-class-features-plugin/src/fields.ts
Outdated
Show resolved
Hide resolved
packages/babel-helper-create-class-features-plugin/src/fields.ts
Outdated
Show resolved
Hide resolved
Can you run |
Done. I've pushed all the snapshot changes. |
The CI failure would be fixed by rebasing; don't worry about it. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
packages/babel-helper-create-class-features-plugin/src/fields.ts
Outdated
Show resolved
Hide resolved
packages/babel-helper-create-class-features-plugin/src/fields.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
Co-authored-by: Nicolò Ribaudo <nicolo.ribaudo@gmail.com>
packages/babel-helper-create-class-features-plugin/src/fields.ts
Outdated
Show resolved
Hide resolved
packages/babel-helper-create-class-features-plugin/src/fields.ts
Outdated
Show resolved
Hide resolved
packages/babel-helper-create-class-features-plugin/src/fields.ts
Outdated
Show resolved
Hide resolved
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Co-authored-by: Justin Ridgewell <justin@ridgewell.name>
Hi @nicolo-ribaudo, @jridgewell, @JLHwung and @colinaaa, I've incorporated all of your suggestions and added the latest changes from the main branch. Would you like to re-review it? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, thanks for working on this!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you!