Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Async do expression should start at async #13534

Merged
merged 2 commits into from Jul 7, 2021
Merged

Async do expression should start at async #13534

merged 2 commits into from Jul 7, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jul 6, 2021 •
edited by gitpod-io bot

Q                       A
Fixed Issues? Async do expression does not start at the async token. (AST Explorer)
Patch: Bug Fix? Y
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: parser Spec: Async do expressions labels Jul 6, 2021
@codesandbox-ci
Copy link

codesandbox-ci bot commented Jul 6, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit b2a7cb6:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47233/

@JLHwung JLHwung mentioned this pull request Jul 6, 2021
Merged
@JLHwung JLHwung merged commit 8a3e0fd into babel:main Jul 7, 2021
@JLHwung JLHwung deleted the fix-async-do-expression-pos branch July 7, 2021 04:09
@sync-by-unito sync-by-unito bot mentioned this pull request Jul 21, 2021
Closed
nicolo-ribaudo pushed a commit to nicolo-ribaudo/babel that referenced this pull request Jul 30, 2021
@JLHwung @nicolo-ribaudo
Async do expression should start at async (babel#13534)
4e70252
@sync-by-unito sync-by-unito bot mentioned this pull request Aug 2, 2021
Closed
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Oct 7, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Oct 7, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@existentialism existentialism existentialism approved these changes

@nicolo-ribaudo nicolo-ribaudo nicolo-ribaudo approved these changes

Assignees
No one assigned
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Bug Fix 🐛 A type of pull request used for our changelog categories Spec: Async do expressions
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@JLHwung @babel-bot @existentialism @nicolo-ribaudo