New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add typeParameters to tagged template visitor keys #13500
Conversation
JLHwung
commented
Jun 22, 2021
•
edited by gitpod-io
bot
edited by gitpod-io
bot
Q | A |
---|---|
Fixed Issues? | Fixes #13492 |
Patch: Bug Fix? | Y |
Major: Breaking Change? | |
Minor: New Feature? | |
Tests Added + Pass? | Yes |
Documentation PR Link | |
Any Dependency Changes? | |
License | MIT |
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/47055/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 0db9957:
|
Uh it looks like I was wrong, it's builder
that inherits from visitor
and visitor
defaults to an empty array 😅
3e7c299
to
c080d9e
Compare
}); | ||
|
||
defineType("ClassPrivateProperty", { | ||
visitor: ["key", "value", "decorators", "typeAnnotation"], |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Added "typeAnnotation"
to visitor keys.
* refactor: move ES2022 AST nodes to core * fix: add typeParameters to visitor keys * chore: update artifacts * fix: add typeAnnotation to visitor keys