Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: remove traverse trap on NODE_ENV == "test" #13475

Merged
merged 1 commit into from Jun 17, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented Jun 16, 2021

Q                       A
Fixed Issues? Resolves #13471
Patch: Bug Fix? Y
Tests Added + Pass? Yes
License MIT

When NODE_ENV is test, Babel assumes infinite cycle is hit when Babel has a queue length > 10000. However, transforming a big file could result to large queue as in #13471 and #12218. Overall the behaviour is inconsistent in different NODE_ENV settings. We should align the behaviour and do not assume 10000 is too much for traverser.

@JLHwung JLHwung added PR: Bug Fix 🐛 A type of pull request used for our changelog categories pkg: traverse labels Jun 16, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46939/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit de43660:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

Copy link
Member

@nicolo-ribaudo nicolo-ribaudo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is meant to help us when developing plugin, but I have never seen this error since I started contributing.

As an alternative, we can keep it but strip it away at publish time.

Copy link
Member

@hzoo hzoo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

agreed, if it's meant for ourselves we should limit it to babel dev

@nicolo-ribaudo nicolo-ribaudo changed the title fix: remove traverse trap on NODE_ENV == "test" fix: remove traverse trap on NODE_ENV == "test" Jun 17, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit dddb413 into babel:main Jun 17, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the remove-traverse-trap branch June 17, 2021 14:29
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 17, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 17, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: traverse PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature Request] Remove or parameterize the queue.length >= 10000 check
5 participants