Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

babel-plugin-transform-spread add missing argument in build calls #13459

Conversation

zxbodya
Copy link
Contributor

@zxbodya zxbodya commented Jun 14, 2021

Q                       A
Patch: Bug Fix? Yes
Major: Breaking Change?
Minor: New Feature?
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

While rebasing TypeScript migration branch found possible bug, introduced in #13439

Adding fix for it, and additional tests.

@babel-bot
Copy link
Collaborator

babel-bot commented Jun 14, 2021

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46849/

@codesandbox-ci
Copy link

codesandbox-ci bot commented Jun 14, 2021

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit a012c55:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo added the PR: Bug Fix 🐛 A type of pull request used for our changelog categories label Jun 14, 2021
@nicolo-ribaudo
Copy link
Member

Thanks!

@JLHwung JLHwung merged commit 66cbd60 into babel:main Jun 14, 2021
@zxbodya zxbodya deleted the fix-babel-plugin-transform-spread-build-file-argument branch June 14, 2021 15:58
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Sep 14, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Sep 14, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Bug Fix 🐛 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants