New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Relax import assertion key-is-type constraint #13409
Conversation
Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46622/ |
This pull request is automatically built and testable in CodeSandbox. To see build info of the built libraries, click here or the icon next to each commit SHA. Latest deployment of this branch, based on commit 752602e:
|
if (keyName !== "type") { | ||
this.raise( | ||
node.key.start, | ||
Errors.ModuleAttributeDifferentFromType, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Note that we can not remove ModuleAttributeDifferentFromType from Error templates because it is still used in parseModuleAttributes
.
Whops, I looked at the code without looking at CI
39a0c52
to
752602e
Compare
This PR relaxes previously implemented constraint that the AssertionKey must be of string value
"type"
. Note that babel parser also supportsmoduleAttributes
, a legacy version ofimportAssertions
which shares similar behaviour. The behaviour inmoduleAttributes
is not changed as the plugin is deprecated and will be removed in Babel 8./cc @xtuc