Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

disallow surrogate in the end of contextual name #13377

Merged
merged 1 commit into from May 27, 2021

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 26, 2021

Q                       A
Fixed Issues? Fixes #13339
Patch: Bug Fix? Y
Tests Added + Pass? Yes
Documentation PR Link
Any Dependency Changes?
License MIT

In this PR we disallow any surrogate start in the end of a contextual name token. It is sufficient to check surrogate start only, if it turns out it is not an identifier char, it will be thrown later when we create a name token, since the starting character must be an identifier start.

@JLHwung JLHwung added PR: Spec Compliance 👓 A type of pull request used for our changelog categories pkg: parser labels May 26, 2021
@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 4b2b609:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/46476/

@JLHwung JLHwung merged commit 079f8cd into babel:main May 27, 2021
@JLHwung JLHwung deleted the fix-async-function-check branch May 27, 2021 02:58
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 26, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 26, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
outdated A closed issue/PR that is archived due to age. Recommended to make a new issue pkg: parser PR: Spec Compliance 👓 A type of pull request used for our changelog categories
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Bug]: Babel misinterprets function𝐬 as function keyword after async
4 participants