Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Better error for export * as ns without the correct plugin #13296

Merged

Conversation

JLHwung
Copy link
Contributor

@JLHwung JLHwung commented May 11, 2021

Q                       A
Fixed Issues? Fixes #13273
Tests Added + Pass? Yes
License MIT

This PR provides better errors when an export * as ns is seen on module transforms.

@JLHwung JLHwung added PR: Polish 💅 A type of pull request used for our changelog categories area: errors labels May 11, 2021
@babel-bot
Copy link
Collaborator

Build successful! You can test your changes in the REPL here: https://babeljs.io/repl/build/45976/

@codesandbox-ci
Copy link

This pull request is automatically built and testable in CodeSandbox.

To see build info of the built libraries, click here or the icon next to each commit SHA.

Latest deployment of this branch, based on commit 6a67aca:

Sandbox Source
babel-repl-custom-plugin Configuration
babel-plugin-multi-config Configuration

@nicolo-ribaudo nicolo-ribaudo changed the title fix: check export specifier in getLocalExportMetadata Better error for export * as ns without the correct plugin May 11, 2021
@nicolo-ribaudo nicolo-ribaudo merged commit 9e241fc into babel:main May 11, 2021
@nicolo-ribaudo nicolo-ribaudo deleted the throw-better-message-on-namespace-export branch May 11, 2021 22:40
@github-actions github-actions bot added the outdated A closed issue/PR that is archived due to age. Recommended to make a new issue label Aug 11, 2021
@github-actions github-actions bot locked as resolved and limited conversation to collaborators Aug 11, 2021
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
area: errors outdated A closed issue/PR that is archived due to age. Recommended to make a new issue PR: Polish 💅 A type of pull request used for our changelog categories
Projects
None yet
4 participants